Skip to content

Add release process and update version string #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

silvanocerza
Copy link
Contributor

This PR adds a workflow to release the tool that similar to the one used for arduino-cli, it also changes the version output to be in line with the arduino-cli.

@silvanocerza silvanocerza requested a review from per1234 December 18, 2020 11:20
@silvanocerza silvanocerza self-assigned this Dec 18, 2020
@silvanocerza silvanocerza force-pushed the scerza/release-process branch from 9c11a86 to a322e1a Compare December 18, 2020 11:23
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Silvano! I tested it out in my fork and there is one thing missing: the gon.config.hcl configuration file for Gon:
https://github.com/arduino/arduino-cli/blob/master/gon.config.hcl

You can see the commit where i added the arduino-lint equivalent in my fork here:
per1234@be03d7d

So you can cherry pick that, or I'm happy to add it in myself if you approve it.

@silvanocerza silvanocerza force-pushed the scerza/release-process branch from a322e1a to dab7922 Compare December 18, 2020 16:41
@silvanocerza
Copy link
Contributor Author

PR updated.

@silvanocerza
Copy link
Contributor Author

Since I'll be on vacation feel free to modify it and merge it as you see fit @per1234.

@rsora rsora requested a review from per1234 December 18, 2020 17:31
@per1234 per1234 force-pushed the scerza/release-process branch from dab7922 to c4af3f7 Compare December 20, 2020 11:07
@per1234
Copy link
Contributor

per1234 commented Dec 21, 2020

Closing in favor of #120

@per1234 per1234 closed this Dec 21, 2020
@per1234 per1234 deleted the scerza/release-process branch December 23, 2020 07:41
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement labels Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants